linux-kernel - Re: regression for m68k/coldfire

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170203151744.GY11210@waldemar-brodkorb.de>
Date:   Fri, 3 Feb 2017 16:17:44 +0100
From:   Waldemar Brodkorb <wbx@...nadk.org>
To:     Laurent Vivier <laurent@...ier.eu>
Cc:     John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
        Greg Ungerer <gerg@...inux.org>,
        Waldemar Brodkorb <wbx@...nadk.org>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        linux-kernel@...r.kernel.org, linux-m68k@...r.kernel.org,
        uclinux-dev@...inux.org, geert@...ux-m68k.org
Subject: Re: regression for m68k/coldfire

Hi,
Laurent Vivier wrote,

> Le 03/02/2017 à 01:35, John Paul Adrian Glaubitz a écrit :
> > On 02/03/2017 01:10 AM, Greg Ungerer wrote:
> >> This is a limitation in the FEC support in QEMU.
> >> This works on real ColdFire hardware (which do support the
> >> FEC MIB stats registers from offset 0x200 - so not 5272).
> >> I sent this patch to the qemu dev list a couple of weeks
> >> back which fixes qemu:
> >>
> >>  http://lists.gnu.org/archive/html/qemu-devel/2017-01/msg01781.html
> >>
> >> I do not believe it has been picked up by QEMU mainline yet
> >> (I will probably have to resend and push a little to get that done).
> > 
> > QEMU upstream can sometimes take a while before they are merging patches,
> > but usually it helps containing the maintainer of this part of the
> > source tree directly.
> > 
> > Unfortunately, mcf5208 is currently unmaintained [1]:
> > 
> > mcf5208
> > S: Orphan
> > F: hw/m68k/mcf5208.c
> > F: hw/m68k/mcf_intc.c
> > F: hw/char/mcf_uart.c
> > F: hw/net/mcf_fec.c
> > 
> > But you can try getting into touch with Laurent Vivier who is the
> > new maintainer of the m68k target. I have CC'ed him.
> > 
> > Adrian
> > 
> >> [1] http://git.qemu.org/?p=qemu.git;a=blob;f=MAINTAINERS
> > 
> 
> Use scripts/get_maintainer.pl on your patch to find the people.
> 
> This patch is on the network part, so you should cc:
> Jason Wang <jasowang@...hat.com> (odd fixer:Network devices)
> 
> If you cc me, you add more chances to have a review ;)

I tried the patch on top of 2.8.0 qemu release and it works for me
with Linux Kernel 4.9.
Thanks for the hint and patch!
I hope Greg's patch get included in the next qemu release.

Btw: Laurent, are you m68k with mmu support are going to be included
upstream? I always carry an old binary for any m68k with mmu testing.

best regards
 Waldemar