lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 3 Feb 2017 17:35:50 -0500
From:   Jon Mason <>
To:     Rafał Miłecki <>
Cc:     David Miller <>,
        BCM Kernel Feedback <>,
        Network Development <>,
        open list <>
Subject: Re: [PATCH 2/3] net: ethernet: bgmac: unify code of the same family

On Fri, Feb 3, 2017 at 4:48 PM, Rafał Miłecki <> wrote:
> On 2017-02-03 22:39, Jon Mason wrote:
>> BCM471X and BCM535X are of the same family (from what I can derive from
>> internal documents).  Group them into the case statement together, which
>> results in more code reuse.
>> Also, use existing helper variables to make the code a little more
>> readable too.
>> Signed-off-by: Jon Mason <>
> I'd like to review it / test it on few devices. Please give me weekend for
> that.

Yes, please test this as much as you can.  The code move was pretty
innocuous, and those are always the times when it comes back to bite


Powered by blists - more mailing lists