linux-kernel - Re: [PATCH 2/3] net: ethernet: bgmac: unify code of the same family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdd5a5472af15d6da11e80306424d8b9@milecki.pl>
Date:   Fri, 03 Feb 2017 22:48:15 +0100
From:   Rafał Miłecki <rafal@...ecki.pl>
To:     Jon Mason <jon.mason@...adcom.com>
Cc:     David Miller <davem@...emloft.net>,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] net: ethernet: bgmac: unify code of the same family

On 2017-02-03 22:39, Jon Mason wrote:
> BCM471X and BCM535X are of the same family (from what I can derive from
> internal documents).  Group them into the case statement together, 
> which
> results in more code reuse.
> 
> Also, use existing helper variables to make the code a little more
> readable too.
> 
> Signed-off-by: Jon Mason <jon.mason@...adcom.com>

I'd like to review it / test it on few devices. Please give me weekend 
for
that.