linux-kernel - Re: [PATCH 1/2] sigaltstack: support SS_AUTODISARM for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrVvKeGGN_eb9_t9KDvDVB8WFM6uZTVsKJLx6TvJ4FrrYw@mail.gmail.com>
Date:   Sun, 5 Feb 2017 10:31:35 -0800
From:   Andy Lutomirski <luto@...capital.net>
To:     Stas Sergeev <stsp@...t.ru>
Cc:     Stas Sergeev <stsp@...rs.sourceforge.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Milosz Tanski <milosz@...in.com>,
        Andy Lutomirski <luto@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Nicolas Pitre <nicolas.pitre@...aro.org>,
        Waiman Long <Waiman.Long@....com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Dmitry Safonov <dsafonov@...tuozzo.com>,
        Wang Xiaoqiang <wangxq10@....edu.cn>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH 1/2] sigaltstack: support SS_AUTODISARM for CONFIG_COMPAT

On Sun, Feb 5, 2017 at 2:12 AM, Stas Sergeev <stsp@...t.ru> wrote:
> Currently SS_AUTODISARM is not supported in compatibility
> mode, but does not return -EINVAL either. This makes dosemu
> built with -m32 on x86_64 to crash. Also the kernel's sigaltstack
> selftest fails if compiled with -m32.
>
> This patch adds the needed support.
>
> Suggesting for -stable.

This looks correct.  I find it odd that we used to check the old sp to
figure out whether to put SA_ONSTACK into the signal frame, but I do
think the new behavior is better.  In any event, this changes the
compat case to work like the native case, and no one noticed when the
native behavior changed, so it's fine by me.

--Andy