linux-kernel - Re: [tip:core/debugobjects] debugobjects: Reduce contention on the global pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170205100344.GA8377@gmail.com>
Date:   Sun, 5 Feb 2017 11:03:44 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     hpa@...or.com, tglx@...utronix.de, linux-kernel@...r.kernel.org,
        changbin.du@...el.com, longman@...hat.com, jstancek@...hat.com,
        akpm@...ux-foundation.org, borntraeger@...ibm.com
Cc:     linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/debugobjects] debugobjects: Reduce contention on the
 global pool_lock


* tip-bot for Waiman Long <tipbot@...or.com> wrote:

> ---
>  lib/debugobjects.c | 31 ++++++++++++++++++++++---------
>  1 file changed, 22 insertions(+), 9 deletions(-)
> 
> diff --git a/lib/debugobjects.c b/lib/debugobjects.c
> index dc78217..5476bbe 100644
> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
> @@ -172,25 +172,38 @@ alloc_object(void *addr, struct debug_bucket *b, struct debug_obj_descr *descr)
>  
>  /*
>   * workqueue function to free objects.
> + *
> + * To reduce contention on the global pool_lock, the actual freeing of
> + * debug objects will be delayed if the pool_lock is busy. We also free
> + * the objects in a batch of 4 for each lock/unlock cycle.
>   */
> +#define ODEBUG_FREE_BATCH	4
>  static void free_obj_work(struct work_struct *work)
>  {

Please put an extra newline before function definitions.

Looks good otherwise!

Thanks,

	Ingo