linux-kernel - Re: [PATCH] staging: fbtft: fbtft-bus.c: Fix checkpatch error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170205103943.GA27540@kroah.com>
Date:   Sun, 5 Feb 2017 11:39:43 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Youngdo Lee <paul.ydlee@...il.com>
Cc:     thomas.petazzoni@...e-electrons.com, noralf@...nnes.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fbtft: fbtft-bus.c: Fix checkpatch error

On Sat, Feb 04, 2017 at 01:42:48PM +0900, Youngdo Lee wrote:
> Fix checkpatch error:
> ERROR: space prohibited before that close parenthesis ')'
> 
> Signed-off-by: Youngdo Lee <paul.ydlee@...il.com>
> ---
>  drivers/staging/fbtft/fbtft-bus.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index ec45043..3ce265d 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -10,6 +10,7 @@
>   *
>   *****************************************************************************/
>  
> +#define	nop_modifier(expr)		(expr)

What?

>  #define define_fbtft_write_reg(func, type, modifier)                          \
>  void func(struct fbtft_par *par, int len, ...)                                \
>  {                                                                             \
> @@ -68,9 +69,9 @@ void func(struct fbtft_par *par, int len, ...)                                \
>  }                                                                             \
>  EXPORT_SYMBOL(func);
>  
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, nop_modifier)

That's really odd.  Don't do crazy things like this to fix odd code.
Fix up the code to not do such looney things in the first place.

thanks,

greg k-h