lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Feb 2017 03:54:35 +0100 From: Andrew Lunn <andrew@...n.ch> To: Eddie Cai <eddie.cai.linux@...il.com> Cc: robh+dt@...nel.org, mark.rutland@....com, heiko@...ech.de, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux@...linux.org.uk, linux-rockchip@...ts.infradead.org, eddie.cai@...k-chips.com, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Hi Eddie > + button@0 { > + gpios = <&gpio0 5 GPIO_ACTIVE_LOW>; > + linux,code = <116>; It is a good idea to use include/dt-bindings/input/input.h and then you can replace <116> with < KEY_POWER > which is more readable. > + label = "GPIO Key Power"; > + linux,input-type = <1>; < EV_KEY > > + gpio-key,wakeup = <1>; This has been replace with wakeup-source. > + debounce-interval = <100>; > + }; > + }; Andrew
Powered by blists - more mailing lists