linux-kernel - Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJrj+DPVw9uZ9VS_mS4U9t8rSKxoQJSzbQK=DgtuVecOoX3u8A@mail.gmail.com>
Date:   Mon, 6 Feb 2017 13:52:01 +0800
From:   Eddie Cai <eddie.cai.linux@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     robh+dt@...nel.org, mark.rutland@....com,
        Heiko Stuebner <heiko@...ech.de>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux@...linux.org.uk,
        linux-rockchip@...ts.infradead.org,
        Eddie Cai <eddie.cai@...k-chips.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

Hi Andrew

2017-02-06 10:54 GMT+08:00 Andrew Lunn <andrew@...n.ch>:
> Hi Eddie
>
>> +             button@0 {
>> +                     gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
>> +                     linux,code = <116>;
>
> It is a good idea to use include/dt-bindings/input/input.h
>
> and then you can replace <116> with < KEY_POWER > which is more
> readable.
Thanks, I will modify it in next version.
>
>> +                     label = "GPIO Key Power";
>> +                     linux,input-type = <1>;
>
> < EV_KEY >
>
>> +                     gpio-key,wakeup = <1>;
>
> This has been replace with wakeup-source.
Thanks, I will modify it in next version
>
>> +                     debounce-interval = <100>;
>> +             };
>> +     };
>
>   Andrew