linux-kernel - Re: [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170206192642.GA22482@obsidianresearch.com>
Date:   Mon, 6 Feb 2017 12:26:42 -0700
From:   Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:     Tadeusz Struk <tadeusz.struk@...el.com>
Cc:     gregkh@...uxfoundation.org, linux-rdma@...r.kernel.org,
        dennis.dalessandro@...el.com, linux-kernel@...r.kernel.org,
        grant.likely@...retlab.ca, dledford@...hat.com, ira.weiny@...el.com
Subject: Re: [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport
 device

On Mon, Feb 06, 2017 at 11:15:33AM -0800, Tadeusz Struk wrote:
> Some hardware has multiple HFIs within the same ASIC, each one on a
> sepatate bus number. In some devices the numbers labeled on the
> faceplate of the device don't match the PCI bus order, and the result
> is that the devices (ports) are probed in the opposite order of their
> port numbers. The result is IB device unit numbers are in reverse order
> from the faceplate numbering. This leads to confusion, and errors.
> Use EPROBE_DEFER error code to enforce correct port order.
> 
> Reviewed-by: Ira Weiny <ira.weiny@...el.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@...el.com>
>  drivers/infiniband/hw/hfi1/chip.c |   95 ++++++++++++++++++++++++++++++++++++-
>  drivers/infiniband/hw/hfi1/chip.h |    2 -
>  drivers/infiniband/hw/hfi1/init.c |    1 
>  3 files changed, 94 insertions(+), 4 deletions(-)

Still no on this from me, this is a horrible abuse of the device core.

Jason