linux-kernel - Re: [PATCH 00/10] Add binding from PS/2 to SMBus for Synaptics and Elan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170206192742.GB17441@dtor-ws>
Date:   Mon, 6 Feb 2017 11:27:42 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Benjamin Tissoires <benjamin.tissoires@...il.com>
Cc:     KT Liao <kt.liao@....com.tw>,
        Andrew Duggan <aduggan@...aptics.com>,
        Adrian Alves <aalves@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-input <linux-input@...r.kernel.org>
Subject: Re: [PATCH 00/10] Add binding from PS/2 to SMBus for Synaptics and
 Elan

Hi Benjamin,

On Mon, Jan 30, 2017 at 02:05:39PM +0100, Benjamin Tissoires wrote:
> Hi Dmitri,
> 
> On Tue, Jan 10, 2017 at 5:11 PM, Benjamin Tissoires
> <benjamin.tissoires@...hat.com> wrote:
> > Hi,
> >
> > Well, this is the last series which enables RMI4 over SMBus for the Thinkpad
> > t*40, t*50, t*60 series. Few comments on the patches:
> >
> > patches 1 to 3 allows the re-routing of the trackstick buttons from the touchpad
> >   to the trackstick
> > patch 4 to 7 allow rmi_smbus to actually control the PS/2 node to not resume and
> >   mess up the configuration after a resume
> > patch 8 was originally sent as a RMI4 specific driver, but I came to realise
> >   that Elan could also benefit from the same driver
> 
> Any comments on the first 8 patches?

I think that by trying to "unwind" unsuccessful SMbus initialization you
make the code much more complicated and fragile. I think we should
select a path (PS/2 or SMbus) and commit to it. If we commit to SMBus
then we need to communicate that fact to psmouse core so that it does
not create input devices or psmouse attributes, and "short-circuit" the
reconnect() routines to simply ignore requests and always report
success.

Thanks.

-- 
Dmitry