linux-kernel - Re: [PATCH] platform/x86: intel_pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Feb 2017 17:32:32 +0530
From:   Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     kbuild test robot <lkp@...el.com>,
        Shanth Murthy <shanth.murthy@...el.com>, kbuild-all@...org,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Zha Qipeng <qipeng.zha@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: intel_pmc_ipc: read s0ix residency API

On Tue, Feb 07, 2017 at 12:19:10PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 6, 2017 at 8:31 PM, Rajneesh Bhardwaj
> <rajneesh.bhardwaj@...el.com> wrote:
> > On Mon, Feb 06, 2017 at 10:01:43PM +0800, kbuild test robot wrote:
> >> Hi Shanth,
> >>
> >> [auto build test ERROR on tip/x86/core]
> >> [also build test ERROR on v4.10-rc7]
> >> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> >>
> >> url:    https://github.com/0day-ci/linux/commits/Shanth-Murthy/platform-x86-intel_pmc_ipc-read-s0ix-residency-API/20170206-213213
> >> config: i386-randconfig-x007-201706 (attached as .config)
> >> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> >> reproduce:
> >>         # save the attached .config to linux build tree
> >>         make ARCH=i386
> >>
> >> All errors (new ones prefixed by >>):
> >>
> >>    drivers/platform/x86/intel_pmc_ipc.c: In function 'gcr_data_readq':
> >> >> drivers/platform/x86/intel_pmc_ipc.c:193:9: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]
> >>      return readq(ipcdev.ipc_base + offset);
> >>             ^~~~~
> >>    cc1: some warnings being treated as errors
> >>
> >> vim +/readq +193 drivers/platform/x86/intel_pmc_ipc.c
> >>
> >>    187        {
> >>    188                return readl(ipcdev.ipc_base + IPC_READ_BUFFER + offset);
> >>    189        }
> >>    190
> >>    191        static inline u64 gcr_data_readq(u32 offset)
> >>    192        {
> >>  > 193                return readq(ipcdev.ipc_base + offset);
> >
> > Seems readq is not available for 32 bit configuration. Will send a fix soon.
> 
> I fixed and pushed to testing. No need to resend.
> Thanks!

Andy, thanks for the fix. We had a look at the patch that was pushed to
testing and think that still one issue exist when we compile with
CONFIG_64BIT not set. Config attached.
(linux-platform-drivers-x86.git/commit/c0baf79f459dbbdfe272dda58d5bcc9a2e585d7e) 

Error:
drivers/built-in.o: In function `intel_pmc_s0ix_counter_read':
(.text+0x7352b4): undefined reference to `__udivdi3'
make[2]: *** [vmlinux] Error 1

In addition to this, please share your thoughts on the below change for IPC
driver.

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index b8a21d7..0284a66 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -999,7 +999,7 @@ config PVPANIC

 config INTEL_PMC_IPC
        tristate "Intel PMC IPC Driver"
-       depends on ACPI
+       depends on ACPI && X86_64
        ---help---
        This driver provides support for PMC control on some Intel
platforms.
        The PMC is an ARC processor which defines IPC commands for
communication




> 
> 
> >
> >>    194        }
> >>    195
> >>    196        static int intel_pmc_ipc_check_status(void)
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko

-- 
Best Regards,
Rajneesh

View attachment "config-32x86" of type "text/plain" (106018 bytes)