linux-kernel - Re: [PATCH] mfd: rtsx: Convert forgotten dev_info() statement to pcr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170208120222.pyhxy2c4yfzy32sj@dell>
Date:   Wed, 8 Feb 2017 12:02:22 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: rtsx: Convert forgotten dev_info() statement to
 pcr_dbg()

On Thu, 02 Feb 2017, Borislav Petkov wrote:

> From: Borislav Petkov <bp@...e.de>
> 
> It is a debugging statement so make it be issued only then.
> 
> No functionality change.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/mfd/rtsx_pcr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index 98029ee0959e..850590aac008 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -927,7 +927,7 @@ static irqreturn_t rtsx_pci_isr(int irq, void *dev_id)
>  
>  static int rtsx_pci_acquire_irq(struct rtsx_pcr *pcr)
>  {
> -	dev_info(&(pcr->pci->dev), "%s: pcr->msi_en = %d, pci->irq = %d\n",
> +	pcr_dbg(pcr, "%s: pcr->msi_en = %d, pci->irq = %d\n",
>  			__func__, pcr->msi_en, pcr->pci->irq);

I usually disapprove of these kinds of abstractions.

What is the point of it?

Why can't you just use dev_dbg()?

>  	if (request_irq(pcr->pci->irq, rtsx_pci_isr,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog