linux-kernel - Re: [PATCH] mfd: rtsx: Convert forgotten dev_info() statement to pcr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Feb 2017 13:54:24 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: rtsx: Convert forgotten dev_info() statement to
 pcr_dbg()

On Wed, Feb 08, 2017 at 12:02:22PM +0000, Lee Jones wrote:
> I usually disapprove of these kinds of abstractions.
> 
> What is the point of it?
> 
> Why can't you just use dev_dbg()?

I was simply following what the rest of the driver does. It has 20
pcr_dbg() calls and 5 dev_dbg().

If you want to address that, then a patch ontop should convert all
pcr_dbg() calls to dev_dbg().

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.