linux-kernel - Re: [PATCH net] net: hns: Fix the device being used for dma mapping during TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-6f3e49ac-6fc0-4d36-a77a-44018a1b2e77-1486635890380@3capp-gmx-bs03>
Date:   Thu, 9 Feb 2017 11:24:50 +0100
From:   "Lino Sanfilippo" <LinoSanfilippo@....de>
To:     "Salil Mehta" <salil.mehta@...wei.com>
Cc:     davem@...emloft.net, salil.mehta@...wei.com,
        yisen.zhuang@...wei.com, mehta.salil.lnk@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com, "Kejian Yan" <yankejian@...wei.com>
Subject: Re: [PATCH net] net: hns: Fix the device being used for dma mapping
 during TX

Hi,

> From: Kejian Yan <yankejian@...wei.com>
> 
> This patch fixes the device being used to DMA map skb->data.
> Erroneous device assignment causes the crash when SMMU is enabled.
> This happens during TX since buffer gets DMA mapped with device
> correspondign to net_device and gets unmapped using the device
> related to DSAF.
> 
> Signed-off-by: Kejian Yan <yankejian@...wei.com>
> Reviewed-by: Yisen Zhuang <yisen.zhuang@...wei.com>
> Signed-off-by: Salil Mehta <salil.mehta@...wei.com>
> ---
>  drivers/net/ethernet/hisilicon/hns/hns_enet.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> index 672b646..2b52a12 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> @@ -305,7 +305,7 @@ int hns_nic_net_xmit_hw(struct net_device *ndev,
>  			struct hns_nic_ring_data *ring_data)
>  {
>  	struct hns_nic_priv *priv = netdev_priv(ndev);
> -	struct device *dev = priv->dev;
> +	struct device *dev = ring_to_dev(ring_data->ring);
>  	struct hnae_ring *ring = ring_data->ring;
>  	struct netdev_queue *dev_queue;
>  	struct skb_frag_struct *frag;
> -- 

I would say it should be the other way around: Use priv->dev for mapping and
unmapping instead of ring_to_dev().

Regards,
Lino