linux-kernel - RE: [PATCH net] net: hns: Fix the device being used for dma mapping during TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Feb 2017 10:20:35 +0000
From:   Salil Mehta <salil.mehta@...wei.com>
To:     YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "Zhuangyuzeng (Yisen)" <yisen.zhuang@...wei.com>,
        "mehta.salil.lnk@...il.com" <mehta.salil.lnk@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        "Yankejian (Hackim Yim)" <yankejian@...wei.com>
Subject: RE: [PATCH net] net: hns: Fix the device being used for dma mapping
 during TX

> -----Original Message-----
> From: Salil Mehta
> Sent: Thursday, February 09, 2017 9:48 AM
> To: 'YUAN Linyu'; davem@...emloft.net
> Cc: Zhuangyuzeng (Yisen); mehta.salil.lnk@...il.com;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Linuxarm;
> Yankejian (Hackim Yim)
> Subject: RE: [PATCH net] net: hns: Fix the device being used for dma
> mapping during TX
> 
> > -----Original Message-----
> > From: YUAN Linyu [mailto:Linyu.Yuan@...atel-sbell.com.cn]
> > Sent: Thursday, February 09, 2017 9:36 AM
> > To: Salil Mehta; davem@...emloft.net
> > Cc: Zhuangyuzeng (Yisen); mehta.salil.lnk@...il.com;
> > netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Linuxarm;
> > Yankejian (Hackim Yim)
> > Subject: RE: [PATCH net] net: hns: Fix the device being used for dma
> > mapping during TX
> >
> >
> >
> > > -----Original Message-----
> > > From: netdev-owner@...r.kernel.org [mailto:netdev-
> > owner@...r.kernel.org]
> > > On Behalf Of Salil Mehta
> > > Sent: Thursday, February 09, 2017 5:24 PM
> > > To: davem@...emloft.net
> > > Cc: salil.mehta@...wei.com; yisen.zhuang@...wei.com;
> > > mehta.salil.lnk@...il.com; netdev@...r.kernel.org;
> > > linux-kernel@...r.kernel.org; linuxarm@...wei.com; Kejian Yan
> > > Subject: [PATCH net] net: hns: Fix the device being used for dma
> > mapping during
> > > TX
> > >
> > > From: Kejian Yan <yankejian@...wei.com>
> > >
> > > This patch fixes the device being used to DMA map skb->data.
> > > Erroneous device assignment causes the crash when SMMU is enabled.
> > > This happens during TX since buffer gets DMA mapped with device
> > > correspondign to net_device and gets unmapped using the device
> > > related to DSAF.
> > >
> > > Signed-off-by: Kejian Yan <yankejian@...wei.com>
> > > Reviewed-by: Yisen Zhuang <yisen.zhuang@...wei.com>
> > > Signed-off-by: Salil Mehta <salil.mehta@...wei.com>
> > > ---
> > >  drivers/net/ethernet/hisilicon/hns/hns_enet.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> > > b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> > > index 672b646..2b52a12 100644
> > > --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> > > +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> > > @@ -305,7 +305,7 @@ int hns_nic_net_xmit_hw(struct net_device
> *ndev,
> > >  			struct hns_nic_ring_data *ring_data)
> > >  {
> > >  	struct hns_nic_priv *priv = netdev_priv(ndev);
> > > -	struct device *dev = priv->dev;
> > > +	struct device *dev = ring_to_dev(ring_data->ring);
> > >  	struct hnae_ring *ring = ring_data->ring;
> > struct device *dev = ring_to_dev(ring); ??????
> Yes, name of the macro is slight misnomer but this gets the dsaf
> device.
> Hope this answers your question?

I realized this lately, I think you meant below:
  	struct hnae_ring *ring = ring_data->ring;
	struct device *dev = ring_to_dev(ring);

I will correct this and float a patch. Thanks!

Best regards
Salil
> 
> Thanks
> Salil
> > >  	struct netdev_queue *dev_queue;
> > >  	struct skb_frag_struct *frag;
> > > --
> > > 1.7.9.5
> > >