linux-kernel - Re: [PATCH] staging: comedi: Fix incorrect type assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <482b9c8a-f48a-8e4c-20b0-c8dfc0ac2ed5@mev.co.uk>
Date:   Thu, 9 Feb 2017 11:22:41 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Karthik Nayak <karthik.188@...il.com>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        kastolom@...il.com
Subject: Re: [PATCH] staging: comedi: Fix incorrect type assignment

On 09/02/2017 11:04, Greg KH wrote:
> On Thu, Feb 09, 2017 at 01:53:56AM +0530, Karthik Nayak wrote:
>> This patch fixes the following sparse error:
>> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types)
>> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:    expected restricted __be32 [usertype] serial_number
>> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:    got unsigned int
>>
>> This is done by removing the whole code block, since the variable
>> 'serial_number' is only assigned but never used.
>>
>> Helped-by: Ian Abbott <abbotti@....co.uk>
>
> There's no such tag, sorry :(
>
> And does this obsolete all of your other ones?  Please make it obvious
> what I am supposed to do here.
>
> I've now dropped all of these patches from my queue.  please resend the
> proper one.
>
> thanks,
>
> greg k-h
>

To add to that, I think the emphasis of the patch title and description 
should now be on the removal of serial_number, with fixing the sparse 
error as a useful side-effect/inspiration.  The patch title should also 
mention ni_pcimio.

Thanks,
Ian.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-