linux-kernel - Re: [PATCH] platform/x86: intel_pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1486639986.2133.425.camel@linux.intel.com>
Date:   Thu, 09 Feb 2017 13:33:06 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>,
        Shanth Murthy <shanth.murthy@...el.com>
Cc:     platform-driver-x86@...r.kernel.org, dvhart@...radead.org,
        qipeng.zha@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: intel_pmc_ipc: read s0ix residency API

On Thu, 2017-02-09 at 12:17 +0530, Rajneesh Bhardwaj wrote:
> On Mon, Feb 06, 2017 at 05:09:51AM -0800, Shanth Murthy wrote:

> > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>
 
> > +static int intel_pmc_s0ix_counter_read(u64 *data)
> > +{
> > +	return -EINVAL;
> > +}
> > +
> 
> How about making it static inline and return -ENOSYS instead of
> -EINVAL?

I'm not sure what's going on.
Your SoB is in this patch and now it feels like you are reviewing this
patch.

What should I do?

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy