linux-kernel - Re: [PATCH] platform/x86: intel_pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170209120259.GA25065@rajaneesh-OptiPlex-9010>
Date:   Thu, 9 Feb 2017 17:32:59 +0530
From:   Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Shanth Murthy <shanth.murthy@...el.com>,
        platform-driver-x86@...r.kernel.org, dvhart@...radead.org,
        qipeng.zha@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: intel_pmc_ipc: read s0ix residency API

On Thu, Feb 09, 2017 at 01:33:06PM +0200, Andy Shevchenko wrote:
> On Thu, 2017-02-09 at 12:17 +0530, Rajneesh Bhardwaj wrote:
> > On Mon, Feb 06, 2017 at 05:09:51AM -0800, Shanth Murthy wrote:
> 
> > > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>
>  
> > > +static int intel_pmc_s0ix_counter_read(u64 *data)
> > > +{
> > > +	return -EINVAL;
> > > +}
> > > +
> > 
> > How about making it static inline and return -ENOSYS instead of
> > -EINVAL?
> 
> I'm not sure what's going on.
> Your SoB is in this patch and now it feels like you are reviewing this
> patch.
> 
> What should I do?

Sorry about the confusion. We will respin the patch and send V2.

> 
> -- 
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Intel Finland Oy

-- 
Best Regards,
Rajneesh