[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e8491e0d1fcb43beb0f17b1f47f73f84@AMSPEX02CL03.citrite.net>
Date: Thu, 9 Feb 2017 14:45:45 +0000
From: Paul Durrant <Paul.Durrant@...rix.com>
To: 'Jan Beulich' <JBeulich@...e.com>
CC: "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
"Boris Ostrovsky" <boris.ostrovsky@...cle.com>,
Juergen Gross <JGross@...e.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Xen-devel] [PATCH 3/3] xen/privcmd: add IOCTL_PRIVCMD_RESTRICT
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@...e.com]
> Sent: 09 February 2017 14:43
> To: Paul Durrant <Paul.Durrant@...rix.com>
> Cc: xen-devel@...ts.xenproject.org; Boris Ostrovsky
> <boris.ostrovsky@...cle.com>; Juergen Gross <JGross@...e.com>; linux-
> kernel@...r.kernel.org
> Subject: Re: [Xen-devel] [PATCH 3/3] xen/privcmd: add
> IOCTL_PRIVCMD_RESTRICT
>
> >>> On 09.02.17 at 15:17, <paul.durrant@...rix.com> wrote:
> > @@ -666,6 +680,20 @@ static long privcmd_ioctl_dm_op(void __user
> *udata)
> > return rc;
> > }
> >
> > +static long privcmd_ioctl_restrict(struct file *file, void __user *udata)
> > +{
> > + struct privcmd_data *data = file->private_data;
> > + domid_t dom;
> > +
> > + if (copy_from_user(&dom, udata, sizeof(dom)))
> > + return -EFAULT;
> > +
> > + /* Set restriction to the specified domain */
> > + data->domid = dom;
> > +
> > + return 0;
> > +}
>
> Is it really intended for the caller to be able to undo this, by passing
> in DOMID_INVALID?
Good point. I was intending to fix that, but forgot.
Paul
>
> Jan
Powered by blists - more mailing lists