linux-kernel - Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFp+6iFrE8oz2By9KR1n51OZZxZ05gStu03bMgD4zVbLXZ5ppQ@mail.gmail.com>
Date:   Thu, 9 Feb 2017 17:38:25 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Roger Quadros <rogerq@...com>
Cc:     Jack Pham <jackp@...eaurora.org>, Peter Chen <peter.chen@....com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Ulf Hansson <ulf.hansson@...aro.org>, broonie@...nel.org,
        sre@...nel.org, "robh+dt" <robh+dt@...nel.org>,
        shawnguo@...nel.org, rjw@...ysocki.net,
        Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
        Heiko Stübner <heiko@...ech.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>, p.zabel@...gutronix.de,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Pawel Moll <pawel.moll@....com>,
        Mark Rutland <mark.rutland@....com>,
        Linux USB Mailing List <linux-usb@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>, s.hauer@...gutronix.de,
        mail@...iej.szmigiero.name, troy.kisky@...ndarydevices.com,
        Fabio Estevam <festevam@...il.com>, oscar@...andei.net,
        Stephen Boyd <stephen.boyd@...aro.org>,
        linux-pm@...r.kernel.org,
        Joshua Clayton <stillcompiling@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        mka@...omium.org, Vaibhav Hiremath <vaibhav.hiremath@...aro.org>,
        Gary Bisson <gary.bisson@...ndarydevices.com>,
        Hans Verkuil <hverkuil@...all.nl>, krzk@...nel.org,
        Sriram Dash <sriram.dash@....com>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>
Subject: Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

On Thu, Feb 9, 2017 at 5:23 PM, Roger Quadros <rogerq@...com> wrote:
>
>
> On 08/02/17 22:43, Jack Pham wrote:
>> Hi Peter, Sriram, Arnd,
>>
>> On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote:
>>> From: Arnd Bergmann <arnd@...db.de>
>>>
>>> For xhci-hcd platform device, all the DMA parameters are not
>>> configured properly, notably dma ops for dwc3 devices. So, set
>>> the dma for xhci from sysdev. sysdev is pointing to device that
>>> is known to the system firmware or hardware.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>> Signed-off-by: Sriram Dash <sriram.dash@....com>
>>> Tested-by: Baolin Wang <baolin.wang@...aro.org>
>>> Tested-by: Vivek Gautam <vivek.gautam@...eaurora.org>
>>> Tested-by: Alexander Sverdlin <alexander.sverdlin@...ia.com>
>>> Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
>>> ---
>>> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
>>> index 6d33b42..7a9c860 100644
>>> --- a/drivers/usb/host/xhci-plat.c
>>> +++ b/drivers/usb/host/xhci-plat.c
>>
>>> -    hcd = usb_create_hcd(driver, &pdev->dev, dev_name(&pdev->dev));
>>> +    hcd = __usb_create_hcd(driver, sysdev, &pdev->dev,
>>> +                           dev_name(&pdev->dev), NULL);
>>
>> As mentioned already in [1], usb_create_shared_hcd() is called to create
>> the second bus, however it also needs to be converted.
>>
>> Not exactly as Roger's suggestion but this worked for me:
>>
>> -       xhci->shared_hcd = usb_create_shared_hcd(driver, &pdev->dev,
>> +       xhci->shared_hcd = __usb_create_hcd(driver, sysdev, &pdev->dev,
>>                         dev_name(&pdev->dev), hcd);
>
> But we're creating a shared_hcd and there is an API for that so why not use it
> instead of calling __usb_create_hcd()?

Do we not want to pass on the DMA configuration from sysdev to
shared_hcd as well?

>
>>         if (!xhci->shared_hcd) {
>>                 ret = -ENOMEM;
>>
>> Without this, SuperSpeed devices fail to enumerate:
>>
>>  usb 2-1: new SuperSpeed USB device number 2 using xhci-hcd
>>  usb 2-1: device descriptor read/8, error -11
>>  usb 2-1: new SuperSpeed USB device number 2 using xhci-hcd
>>  usb 2-1: device descriptor read/8, error -11
>>  usb 2-1: new SuperSpeed USB device number 3 using xhci-hcd
>>  usb 2-1: device descriptor read/8, error -11
>>  usb 2-1: new SuperSpeed USB device number 3 using xhci-hcd
>>  usb 2-1: device descriptor read/8, error -11
>>  <and continues...>
>>
>> Thanks,
>> Jack
>>
>> [1] https://lkml.org/lkml/2016/12/9/240
>>
>
> --
> cheers,
> -roger
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project