linux-kernel - Re: [PATCH] i2c: designware: Fix regression when dynamic TAR update is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1486670858.2133.436.camel@linux.intel.com>
Date:   Thu, 09 Feb 2017 22:07:38 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Shah Nehal-Bakulchandra <Nehal-Bakulchandra.Shah@....com>,
        jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com
Cc:     lucas.demarchi@...el.com, wsa@...-dreams.de,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shyam-sundar.S-k@....com,
        Suravee Suthikulpanit <suravee.suthikulpanit@....com>
Subject: Re: [PATCH] i2c: designware: Fix regression when dynamic TAR update
 is disabled

On Fri, 2017-02-10 at 01:20 +0530, Shah Nehal-Bakulchandra wrote:
> The following commit causes a regression when dynamic TAR update is
> disabled:
> 
>      commit 63d0f0a6952a1a02bc4f116b7da7c7887e46efa3 ("i2c:
> designware:
>      detect when dynamic tar update is possible")

Please, leave just 12 characters, it still enough.

> In such case, the DW_IC_CON_10BITADDR_MASTER is R/W, and is changed
> by the logic that's trying to detect  dynamic TAR update.The original
> value of DW_IC_CON_10BITADDR_MASTER bit should be restored.
> 

+ Fixes tag?

> Signed-off-by: Shah Nehal-Bakulchandra <Nehal-
> bakulchandra.Shah@....com>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> ---
>  drivers/i2c/busses/i2c-designware-core.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-core.c
> b/drivers/i2c/busses/i2c-designware-core.c
> index 6d81c56..0c57166 100644
> --- a/drivers/i2c/busses/i2c-designware-core.c
> +++ b/drivers/i2c/busses/i2c-designware-core.c
> @@ -987,6 +987,11 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
>  	    (reg & DW_IC_CON_10BITADDR_MASTER)) {
>  		dev->dynamic_tar_update_enabled = true;
>  		dev_dbg(dev->dev, "Dynamic TAR update enabled");
> +	} else {
> +		/* If test is failed then restore the original value
> */

> +		dev->dynamic_tar_update_enabled = false;

It's default.

> +		dev_dbg(dev->dev, "Dynamic TAR update disable restore
> the value");

I think this is useless. Either you have enabled message, or have
nothing.

> +		dw_writel(dev, reg, DW_IC_CON);
>  	}
>  
>  	i2c_dw_release_lock(dev);

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy