linux-kernel - Re: [PATCH v2 3/4] leds: Add LED support for MT6323 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39b1c6ec-408c-bb92-f937-d477afa626a5@gmail.com>
Date:   Thu, 9 Feb 2017 21:35:26 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     sean.wang@...iatek.com, rpurdie@...ys.net, lee.jones@...aro.org,
        matthias.bgg@...il.com, robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, linux-leds@...r.kernel.org,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        keyhaede@...il.com
Subject: Re: [PATCH v2 3/4] leds: Add LED support for MT6323 PMIC

On 02/09/2017 03:23 PM, Pavel Machek wrote:
> Hi!
> 
>>> +/*
>>> + * Register for MT6323_ISINK_CON0 to setup the
>>> + * duty cycle of the blink
>>> + */
>>> +#define MT6323_ISINK_CON0(i)		(MT6323_ISINK0_CON0 + 0x8 * (i))
>>> +#define MT6323_ISINK_DIM_DUTY_MASK	(0x1f << 8)
>>> +#define MT6323_ISINK_DIM_DUTY(i)	(((i) << 8) & \
>>> +					MT6323_ISINK_DIM_DUTY_MASK)
>>> +
>>> +/*
>>> + * Register to setup the period of the blink
>>> + */
>>
>> This fits in a single line, so can be wrapped with /* */ like :
> 
> People do this to make blocks stand out, and to make it similar to other blocks
> above. I believe this is ok.

It generates unnecessary lines of code, but I'm not going to
argue, let's leave it to the developer's taste.

-- 
Best regards,
Jacek Anaszewski