linux-kernel - Re: [GIT PULL] PCI fixes for v4.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1601856.9nRGEkG20k@aspire.rjw.lan>
Date:   Fri, 10 Feb 2017 13:39:24 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Bjorn Helgaas <helgaas@...nel.org>, Lukas Wunner <lukas@...ner.de>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bart Van Assche <bart.vanassche@...disk.com>,
        Christoph Hellwig <hch@....de>,
        Yinghai Lu <yinghai@...nel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Ashok Raj <ashok.raj@...el.com>,
        Keith Busch <keith.busch@...el.com>
Subject: Re: [GIT PULL] PCI fixes for v4.10

On Thursday, February 09, 2017 02:11:54 PM Bjorn Helgaas wrote:
> On Thu, Feb 09, 2017 at 09:09:50AM -0600, Bjorn Helgaas wrote:
> > [+cc Ashok, Keith]
> > 
> > On Thu, Feb 09, 2017 at 05:06:48AM +0100, Lukas Wunner wrote:
> > > On Wed, Feb 08, 2017 at 01:22:56PM -0600, Bjorn Helgaas wrote:
> > > > Bjorn Helgaas (1):
> > > >       Revert "PCI: pciehp: Add runtime PM support for PCIe hotplug ports"
> > > 
> > > What's the rationale for reverting this?
> > > 
> > > You've received patches to fix the issue on both affected machines,
> > > so a revert seems unnecessary:
> > > 
> > > https://patchwork.kernel.org/patch/9557113/
> > > https://patchwork.kernel.org/patch/9562007/
> > 
> > I don't think we've gotten to the root cause of the problem yet,
> > and I don't want to throw in fixes at the last minute without a better
> > understanding of it.
> > 
> > PCIe hotplug hardware is not very complicated, it hasn't changed in
> > many years, and at least for the Intel hardware in question, is
> > generally pretty well-tested with Windows.  So I want to be careful
> > about asserting that this new piece of hardware is broken.
> 
> I apologize: I had quirks on the brain, but neither of the patches
> above is device-specific.  So neither is claiming broken hardware.
> 
> However, 9557113 claims we get unwanted PME interrupts if the slot is
> occupied when we suspend to D3hot.  This is what I want to explore
> further, because that hardware behavior doesn't really make sense to
> me.
> 
> 9562007 apparently fixes something, but at this point it's a debugging
> patch (no changelog or signed-off-by) so not a candidate for tossing
> into v4.10 at this late date.

Right.

FWIW, my view on this is that it woundn't really hurt to allow Thunderbolt
ports only to use runtime PM for the time being while the more general
(PCIe hotplug ports) case is under investigation.

That shouldn't made the code in question excessively complex and the
Thunderbolt special case should be easy enough to get rid of when we
know what to do in general here.

OTOH, the users of the systems with Thunderbolt would benefit from
reduced energy consumption in the meantime.

Thanks,
Rafael