linux-kernel - Re: [PATCH] spi-nor: use true/false for bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170212230144.22188f98@bbrezillon>
Date:   Sun, 12 Feb 2017 23:01:44 +0100
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Nicholas Mc Guire <der.herr@...r.at>
Cc:     Cyrille Pitchen <cyrille.pitchen@...el.com>,
        Marek Vasut <marek.vasut@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Richard Weinberger <richard@....at>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH] spi-nor: use true/false for bool

+Mika

On Sun, 12 Feb 2017 22:50:44 +0100
Boris Brezillon <boris.brezillon@...e-electrons.com> wrote:

> On Sun, 12 Feb 2017 17:43:31 +0100
> Nicholas Mc Guire <der.herr@...r.at> wrote:
> 
> > writeable in struct intel_spi is a boolean and assignment should be to 
> > true/false not 1/0 as recommended by boolinit.cocci.
> > 
> > Signed-off-by: Nicholas Mc Guire <der.herr@...r.at>  
> 
> Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>

As asked in my other review, please use the 'mtd: spi-nor: intel'
prefix (or anything that would clarify the scope of this patch, like
'mtd: spi-nor/intel: ').

Thanks,

Boris

> 
> > ---
> > 
> > make coccicheck complained with:
> >  ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1
> > 
> > Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
> > 
> > Patch is against 4.10-rc6 (localversion-next is next-20170210)
> > 
> >  drivers/mtd/spi-nor/intel-spi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> > index a10f602..e43ce63 100644
> > --- a/drivers/mtd/spi-nor/intel-spi.c
> > +++ b/drivers/mtd/spi-nor/intel-spi.c
> > @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
> >  		 * whole partition read-only to be on the safe side.
> >  		 */
> >  		if (intel_spi_is_protected(ispi, base, limit))
> > -			ispi->writeable = 0;
> > +			ispi->writeable = false;
> >  
> >  		end = (limit << 12) + 4096;
> >  		if (end > part->size)  
>