linux-kernel - Re: [PATCH] spi-nor: use ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170212230410.183be6a7@bbrezillon>
Date:   Sun, 12 Feb 2017 23:04:10 +0100
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Nicholas Mc Guire <der.herr@...r.at>
Cc:     Cyrille Pitchen <cyrille.pitchen@...el.com>,
        Marek Vasut <marek.vasut@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Richard Weinberger <richard@....at>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH] spi-nor: use ERR_CAST in return

+Mika

On Sun, 12 Feb 2017 22:45:43 +0100
Boris Brezillon <boris.brezillon@...e-electrons.com> wrote:

> On Sun, 12 Feb 2017 17:43:43 +0100
> Nicholas Mc Guire <der.herr@...r.at> wrote:
> 
> > This fixes a sparse warning about   
> 
> Your commit message seems to be incomplete.

And here too, please change the prefix to "mtd: spi-nor: intel: ".

Thanks,

Boris

> 
> Once fixed,
> 
> Acked-by: Boris Brezillon <boris.brezilon@...e-electrons.com>
> 
> > 
> > Signed-off-by: Nicholas Mc Guire <der.herr@...r.at>
> > ---
> > 
> > sparse complained about:
> > drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return expression (different address spaces)
> > drivers/mtd/spi-nor/intel-spi.c:731:28:    expected struct intel_spi *
> > drivers/mtd/spi-nor/intel-spi.c:731:28:    got void [noderef] <asn:2>*base
> > 
> > Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
> > 
> > Patch is against 4.10-rc6 (localversion-next is next-20170210)
> > 
> >  drivers/mtd/spi-nor/intel-spi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> > index e43ce63..986a3d0 100644
> > --- a/drivers/mtd/spi-nor/intel-spi.c
> > +++ b/drivers/mtd/spi-nor/intel-spi.c
> > @@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev,
> >  
> >  	ispi->base = devm_ioremap_resource(dev, mem);
> >  	if (IS_ERR(ispi->base))
> > -		return ispi->base;
> > +		return ERR_CAST(ispi->base);
> >  
> >  	ispi->dev = dev;
> >  	ispi->info = info;  
>