[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170214034703.GC3537@vireshk-i7>
Date: Tue, 14 Feb 2017 09:17:03 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc: Linux PM <linux-pm@...r.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: PATCH] cpufreq: Do not clear real_cpus mask on policy init
On 13-02-17, 13:44, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> If new_policy is set in cpufreq_online(), the policy object has just
> been created and its real_cpus mask has been zeroed on allocation,
> and the driver's ->init() callback should not touch it.
>
> It doesn't need to be cleared again, so don't do that.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
> drivers/cpufreq/cpufreq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: linux-pm/drivers/cpufreq/cpufreq.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq.c
> +++ linux-pm/drivers/cpufreq/cpufreq.c
> @@ -1166,8 +1166,6 @@ static int cpufreq_online(unsigned int c
> if (new_policy) {
> /* related_cpus should at least include policy->cpus. */
> cpumask_copy(policy->related_cpus, policy->cpus);
> - /* Clear mask of registered CPUs */
> - cpumask_clear(policy->real_cpus);
> }
>
> /*
Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
viresh
Powered by blists - more mailing lists