linux-kernel - Re: [PATCH] cpufreq: make ti-cpufreq explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170214034914.GD3537@vireshk-i7>
Date:   Tue, 14 Feb 2017 09:19:14 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org, Dave Gerlach <d-gerlach@...com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH] cpufreq: make ti-cpufreq explicitly non-modular

On 13-02-17, 19:45, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/cpufreq/Kconfig.arm:config ARM_TI_CPUFREQ
> drivers/cpufreq/Kconfig.arm:    bool "Texas Instruments CPUFreq support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: Dave Gerlach <d-gerlach@...com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Cc: linux-pm@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/cpufreq/ti-cpufreq.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
> index 7ff7ae3c3911..a7b5658c0460 100644
> --- a/drivers/cpufreq/ti-cpufreq.c
> +++ b/drivers/cpufreq/ti-cpufreq.c
> @@ -17,7 +17,7 @@
>  #include <linux/cpu.h>
>  #include <linux/io.h>
>  #include <linux/mfd/syscon.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
>  #include <linux/pm_opp.h>
> @@ -265,8 +265,4 @@ static int ti_cpufreq_init(void)
>  
>  	return ret;
>  }
> -module_init(ti_cpufreq_init);
> -
> -MODULE_DESCRIPTION("TI CPUFreq/OPP hw-supported driver");
> -MODULE_AUTHOR("Dave Gerlach <d-gerlach@...com>");
> -MODULE_LICENSE("GPL v2");
> +device_initcall(ti_cpufreq_init);

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh