lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Feb 2017 09:09:52 -0800 From: David Daney <ddaney@...iumnetworks.com> To: Arnd Bergmann <arnd@...db.de>, George Cherian <george.cherian@...ium.com>, Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net> Cc: David Daney <david.daney@...ium.com>, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] crypto: cavium: fix Kconfig dependencies On 02/14/2017 09:07 AM, Arnd Bergmann wrote: > The driver fails to build if MSI support is disabled: > > In file included from /git/arm-soc/drivers/crypto/cavium/cpt/cptpf_main.c:18:0: > drivers/crypto/cavium/cpt/cptpf.h:57:20: error: array type has incomplete element type 'struct msix_entry' > struct msix_entry msix_entries[CPT_PF_MSIX_VECTORS]; > ^~~~~~~~~~~~ > drivers/crypto/cavium/cpt/cptpf_main.c: In function 'cpt_enable_msix': > drivers/crypto/cavium/cpt/cptpf_main.c:344:8: error: implicit declaration of function 'pci_enable_msix';did you mean 'cpt_enable_msix'? [-Werror=implicit-function-declaration] > > On the other hand, it doesn't seem to have any build dependency on ARCH_THUNDER, > so let's allow compile-testing to catch this kind of problem more easily. > The 64-bit dependency is needed for the use of readq/writeq. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > drivers/crypto/cavium/cpt/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/crypto/cavium/cpt/Kconfig b/drivers/crypto/cavium/cpt/Kconfig > index 247f1cbbefc1..cbd51b1aa046 100644 > --- a/drivers/crypto/cavium/cpt/Kconfig > +++ b/drivers/crypto/cavium/cpt/Kconfig > @@ -7,7 +7,8 @@ config CRYPTO_DEV_CPT > > config CAVIUM_CPT > tristate "Cavium Cryptographic Accelerator driver" > - depends on ARCH_THUNDER > + depends on ARCH_THUNDER || COMPILE_TEST > + depends on PCI_MSI && 64BIT Perhaps we should select PCI and PCI_MSI instead. These systems cannot function without those. > select CRYPTO_DEV_CPT > help > Support for Cavium CPT block found in octeon-tx series of >
Powered by blists - more mailing lists