linux-kernel - Re: [PATCH]staging: fbtft: Fix sparse warnings about endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170214171825.GA1625@kroah.com>
Date:   Tue, 14 Feb 2017 09:18:25 -0800
From:   Greg KH <gregkh@...uxfoundation.org>
To:     maomao xu <albert008.xu@...il.com>
Cc:     thomas.petazzoni@...e-electrons.com, noralf@...nnes.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]staging: fbtft: Fix sparse warnings about endianness

On Tue, Feb 14, 2017 at 04:53:10PM +0800, maomao xu wrote:
>     Fixed sparse warnings about endianness. E.g.:
> 
>     warning: incorrect type in assignment (different base types)

Why are these lines indented?

> Signed-off-by: maomao xu <albert008.xu@...il.com>
> 
> diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
> index d868405..ffb9a3b 100644
> --- a/drivers/staging/fbtft/fbtft-io.c
> +++ b/drivers/staging/fbtft/fbtft-io.c
> @@ -71,7 +71,7 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len)
>  			src++;
>  		}
>  		tmp |= ((*src & 0x0100) ? 1 : 0);
> -		*(u64 *)dst = cpu_to_be64(tmp);
> +		*(__be64 *)dst = cpu_to_be64(tmp);

Really?  That seems very odd.  I need a maintainer's ack for this before
I can take it...

thanks,

greg k-h