linux-kernel - [PATCH 6/8] LinuxPPS: pps_parport: Ignore interrupt invoked less than 0.5sec after previous.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1487169069-15721-7-git-send-email-immortalguardian1@gmail.com>
Date:   Wed, 15 Feb 2017 17:31:07 +0300
From:   Andrey Drobyshev <immortalguardian1@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     gq@...msu.su, giometti@...eenne.com
Subject: [PATCH 6/8] LinuxPPS: pps_parport: Ignore interrupt invoked less than 0.5sec after previous.

From: Alexander GQ Gerasiov <gq@...msu.su>

On some devices interrupt may be invoked by parasitic assert event produced
while switching from high to low. Such interrupt should be ignored.

Signed-off-by: Alexander GQ Gerasiov <gq@...msu.su>
---
 drivers/pps/clients/pps_parport.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/pps/clients/pps_parport.c b/drivers/pps/clients/pps_parport.c
index 37094b0..39c1fea 100644
--- a/drivers/pps/clients/pps_parport.c
+++ b/drivers/pps/clients/pps_parport.c
@@ -69,6 +69,8 @@ static void parport_irq(void *handle)
 	struct pps_event_time ts_assert, ts_clear;
 	struct pps_client_pp *dev = handle;
 	struct parport *port = dev->pardev->port;
+	static struct pps_event_time prev;
+	static struct timespec64 ts_delta;
 	unsigned int i;
 	unsigned long flags;
 
@@ -95,9 +97,14 @@ static void parport_irq(void *handle)
 	/* check the signal (no signal means the pulse is lost this time) */
 	if (!signal_is_set(port)) {
 		local_irq_restore(flags);
-		dev_err(dev->pps->dev, "lost the signal\n");
+		ts_delta = timespec64_sub(ts_assert.ts_real, prev.ts_real);
+		/* do not print error message in case interrupt handler is
+		 * invoked by parasitic assert event */
+		if (timespec64_to_ns(&ts_delta) > (NSEC_PER_SEC / 2))
+			dev_err(dev->pps->dev, "lost the signal\n");
 		goto out_none;
 	}
+	prev = ts_assert;
 
 	/* poll the port until the signal is unset */
 	for (i = dev->cw; i; i--)
-- 
2.1.4