linux-kernel - [PATCH 5/8] LinuxPPS: pps_parport: Do not generate assert in case of lost signal.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1487169069-15721-6-git-send-email-immortalguardian1@gmail.com>
Date:   Wed, 15 Feb 2017 17:31:06 +0300
From:   Andrey Drobyshev <immortalguardian1@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     gq@...msu.su, giometti@...eenne.com
Subject: [PATCH 5/8] LinuxPPS: pps_parport: Do not generate assert in case of lost signal.

From: Alexander GQ Gerasiov <gq@...msu.su>

Since clear timeout is non-zero, some clear event capture is requested.
Therefore, if signal is lost we shouldn't generate assert event alone.

Signed-off-by: Alexander GQ Gerasiov <gq@...msu.su>
---
 drivers/pps/clients/pps_parport.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/pps/clients/pps_parport.c b/drivers/pps/clients/pps_parport.c
index 83797d8..37094b0 100644
--- a/drivers/pps/clients/pps_parport.c
+++ b/drivers/pps/clients/pps_parport.c
@@ -96,7 +96,7 @@ static void parport_irq(void *handle)
 	if (!signal_is_set(port)) {
 		local_irq_restore(flags);
 		dev_err(dev->pps->dev, "lost the signal\n");
-		goto out_assert;
+		goto out_none;
 	}

 	/* poll the port until the signal is unset */
@@ -118,6 +118,9 @@ static void parport_irq(void *handle)
 		dev->cw_err = 0;
 	}

+out_none:
+	return;
+
 out_assert:
 	/* fire assert event */
 	pps_event(dev->pps, &ts_assert,
-- 
2.1.4