linux-kernel - Re: [PATCH 1/2] fpga: Add flag to indicate bitstream needs decrypting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8f9c064-3db1-6753-7b6d-dd6401274f03@xilinx.com>
Date:   Wed, 15 Feb 2017 16:03:41 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     <mdf@...nel.org>, <linux-fpga@...r.kernel.org>
CC:     Moritz Fischer <moritz.fischer@...us.com>,
        Alan Tull <atull@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] fpga: Add flag to indicate bitstream needs decrypting

On 15.2.2017 01:31, mdf@...nel.org wrote:
> From: Moritz Fischer <moritz.fischer@...us.com>
> 
> Add a flag that is passed to the write_init() callback, indicating
> that the bitstream is encrypted.
> 
> The low-level driver will deal with the flag, or return an error,
> if encrypted bitstreams are not supported.
> 
> Signed-off-by: Moritz Fischer <moritz.fischer@...us.com>
> Cc: Alan Tull <atull@...nel.org>
> Cc: Michal Simek <michal.simek@...inx.com>
> Cc: Sören Brinkmann <soren.brinkmann@...inx.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-fpga@...r.kernel.org
> ---
>  include/linux/fpga/fpga-mgr.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
> index 57beb5d..1355d8a 100644
> --- a/include/linux/fpga/fpga-mgr.h
> +++ b/include/linux/fpga/fpga-mgr.h
> @@ -70,6 +70,7 @@ enum fpga_mgr_states {
>   */
>  #define FPGA_MGR_PARTIAL_RECONFIG	BIT(0)
>  #define FPGA_MGR_EXTERNAL_CONFIG	BIT(1)
> +#define FPGA_MGR_DECRYPT_BITSTREAM	BIT(2)
>  
>  /**
>   * struct fpga_image_info - information specific to a FPGA image
> 

Isn't it better to state that bitstream is encrypted
instead of saying that bitstream requires decryption?

Your second patch is saying add support for encrypted bitstreams.

M