linux-kernel - Re: [PATCH 1/2] fpga: Add flag to indicate bitstream needs decrypting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANk1AXQL0+tfBnGPuMJ+o_YDjMMngFLeXJPRzNO_LRwr1sMZXw@mail.gmail.com>
Date:   Wed, 15 Feb 2017 10:30:52 -0600
From:   Alan Tull <atull@...nel.org>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     Moritz Fischer <mdf@...nel.org>, linux-fpga@...r.kernel.org,
        Moritz Fischer <moritz.fischer@...us.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] fpga: Add flag to indicate bitstream needs decrypting

On Wed, Feb 15, 2017 at 9:03 AM, Michal Simek <michal.simek@...inx.com> wrote:
> On 15.2.2017 01:31, mdf@...nel.org wrote:
>> From: Moritz Fischer <moritz.fischer@...us.com>
>>
>> Add a flag that is passed to the write_init() callback, indicating
>> that the bitstream is encrypted.
>>
>> The low-level driver will deal with the flag, or return an error,
>> if encrypted bitstreams are not supported.
>>
>> Signed-off-by: Moritz Fischer <moritz.fischer@...us.com>
>> Cc: Alan Tull <atull@...nel.org>
>> Cc: Michal Simek <michal.simek@...inx.com>
>> Cc: Sören Brinkmann <soren.brinkmann@...inx.com>
>> Cc: linux-kernel@...r.kernel.org
>> Cc: linux-fpga@...r.kernel.org
>> ---
>>  include/linux/fpga/fpga-mgr.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
>> index 57beb5d..1355d8a 100644
>> --- a/include/linux/fpga/fpga-mgr.h
>> +++ b/include/linux/fpga/fpga-mgr.h
>> @@ -70,6 +70,7 @@ enum fpga_mgr_states {
>>   */
>>  #define FPGA_MGR_PARTIAL_RECONFIG    BIT(0)
>>  #define FPGA_MGR_EXTERNAL_CONFIG     BIT(1)
>> +#define FPGA_MGR_DECRYPT_BITSTREAM   BIT(2)
>>
>>  /**
>>   * struct fpga_image_info - information specific to a FPGA image
>>
>
> Isn't it better to state that bitstream is encrypted
> instead of saying that bitstream requires decryption?

Such as FPGA_MGR_ENCRYPTED_BITSTREAM  ?

Also please consider adding a DT property such that the FPGA region
code will set this flag similar to how the DTO sets up other FPGA
image info.

Alan

>
> Your second patch is saying add support for encrypted bitstreams.
>
> M
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html