linux-kernel - Re: [PATCH 1/2] fpga: Add flag to indicate bitstream needs decrypting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAtXAHfkiRYD68BRydFFd4OmdHaf9A+kmyOLkH0qNM8VL7G2Og@mail.gmail.com>
Date:   Wed, 15 Feb 2017 19:02:44 +0100
From:   Moritz Fischer <moritz.fischer@...us.com>
To:     Alan Tull <atull@...nel.org>
Cc:     Michal Simek <michal.simek@...inx.com>, linux-fpga@...r.kernel.org,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] fpga: Add flag to indicate bitstream needs decrypting

On Wed, Feb 15, 2017 at 5:30 PM, Alan Tull <atull@...nel.org> wrote:
> On Wed, Feb 15, 2017 at 9:03 AM, Michal Simek <michal.simek@...inx.com> wrote:

>>>  #define FPGA_MGR_PARTIAL_RECONFIG    BIT(0)
>>>  #define FPGA_MGR_EXTERNAL_CONFIG     BIT(1)
>>> +#define FPGA_MGR_DECRYPT_BITSTREAM   BIT(2)
>>>
>>>  /**
>>>   * struct fpga_image_info - information specific to a FPGA image
>>>
>>
>> Isn't it better to state that bitstream is encrypted
>> instead of saying that bitstream requires decryption?
>
> Such as FPGA_MGR_ENCRYPTED_BITSTREAM  ?

Yeah, can do. This was basically a 'redo' of my earlier 'capability' based
patchset. There it made more sense to have a 'can decrypt' capability.

> Also please consider adding a DT property such that the FPGA region
> code will set this flag similar to how the DTO sets up other FPGA
> image info.

Yeah, had that on my list. Can add that to v3.

Cheers,

Moritz