linux-kernel - Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1487129480.6214.39.camel@perches.com>
Date:   Tue, 14 Feb 2017 19:31:20 -0800
From:   Joe Perches <joe@...ches.com>
To:     SIMRAN SINGHAL <singhalsimran0@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote:
> Yes, I totally agree with joe.
> 
> But as there is no coding style issue in this patch.

Style is more than just checkpatch conformity.

> So, do I have to resend the complete patch series again?

I'm not applying any of these so that's entirely up
to Greg.

Perhaps he might apply the first 5 patches and reject
this one, maybe he might apply all the patches.

In any case, do strive to develop some reasonable
semblance of style and do more than just checkpatch
suggested patches and find and fix some actual defect
somewhere.