linux-kernel - Re: [PATCH] net: ethernet: ti: cpsw: use var instead of func for usage count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170214.223056.1842864503781156614.davem@davemloft.net>
Date:   Tue, 14 Feb 2017 22:30:56 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ivan.khoronzhuk@...aro.org
Cc:     mugunthanvnm@...com, grygorii.strashko@...com,
        netdev@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: cpsw: use var instead of func for
 usage count

From: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
Date: Tue, 14 Feb 2017 16:02:36 +0200

> The usage count function is based on ndev_running flag that is
> updated before calling ndo_open/close, but if ndo is called in
> another place, as with suspend/resume, the counter is not changed,
> that breaks sus/resume. For common resource no difference which
> device is using it, does matter only device count. So, replace
> usage count function on var and inc and dec it in ndo_open/close.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
> ---
> Based on net-next/master

Applied, thanks.