linux-kernel - Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3062753.kLFTTf9n8o@avalon>
Date:   Thu, 16 Feb 2017 09:32:45 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Kevin Hilman <khilman@...nel.org>,
        Sekhar Nori <nsekhar@...com>,
        Patrick Titiano <ptitiano@...libre.com>,
        Michael Turquette <mturquette@...libre.com>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Alexandre Bailon <abailon@...libre.com>,
        David Lechner <david@...hnology.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Lad Prabhakar <prabhakar.csengg@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org
Subject: Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port

Hi Rob,

On Wednesday 15 Feb 2017 16:08:22 Rob Herring wrote:
> On Tue, Feb 07, 2017 at 05:41:16PM +0100, Bartosz Golaszewski wrote:
> > This makes the example more or less correspond with the da850-evm
> > hardware setup.
> > 
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> > ---
> > 
> >  .../devicetree/bindings/media/ti,da850-vpif.txt    | 35 +++++++++++++----
> >  1 file changed, 29 insertions(+), 6 deletions(-)
> 
> Spoke too soon...
> 
> > diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> > b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt index
> > 9c7510b..543f6f3 100644
> > --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> > +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> > @@ -28,19 +28,27 @@ I2C-connected TVP5147 decoder:
> >  		reg = <0x217000 0x1000>;
> >  		interrupts = <92>;
> > 
> > -		port {
> > -			vpif_ch0: endpoint@0 {
> > +		port@0 {
> > +			vpif_input_ch0: endpoint@0 {
> >  				reg = <0>;
> >  				bus-width = <8>;
> > -				remote-endpoint = <&composite>;
> > +				remote-endpoint = <&composite_in>;
> >  			};
> > 
> > -			vpif_ch1: endpoint@1 {
> > +			vpif_input_ch1: endpoint@1 {
> >  				reg = <1>;
> >  				bus-width = <8>;
> >  				data-shift = <8>;
> >  			};
> >  		};
> > +
> > +		port@1 {
> 
> The binding doc says nothing about supporting a 2nd port.
> 
> > +			vpif_output_ch0: endpoint@0 {
> > +				reg = <0>;
> 
> Don't need reg here.

And the node should then be named endpoint, not endpoint@0.

> > +				bus-width = <8>;
> > +				remote-endpoint = <&composite_out>;
> > +			};
> > +		};
> >  	};

-- 
Regards,

Laurent Pinchart