linux-kernel - Re: [PATCH 2/2] brcmfmac: don't warn user if loading firmware file with NVRAM fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de837236542d5b762d97e4d5a55cd589@milecki.pl>
Date:   Thu, 16 Feb 2017 08:25:42 +0100
From:   Rafał Miłecki <rafal@...ecki.pl>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Rafał Miłecki <zajec5@...il.com>,
        Ming Lei <ming.lei@...onical.com>,
        "Luis R . Rodriguez" <mcgrof@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        "open list:TI WILINK WIRELES..." <linux-wireless@...r.kernel.org>,
        brcm80211-dev-list.pdl@...adcom.com
Subject: Re: [PATCH 2/2] brcmfmac: don't warn user if loading firmware file
 with NVRAM fails

On 2017-02-16 02:19, Andy Shevchenko wrote:
> On Thu, Feb 16, 2017 at 12:29 AM, Rafał Miłecki <zajec5@...il.com> 
> wrote:
>> From: Rafał Miłecki <rafal@...ecki.pl>
>> 
>> This isn't critical as we use platform NVRAM as fallback and it's very
>> common case of all Broadcom home routers. Thanks for the new firmware
>> loading function we can achieve this by simply passing FW_OPT_NO_WARN.
>> 
> 
> What kind of warning you are talking about?
> 
> On Intel Edison brcmfmac isn't backed up by NVRAM (there no such) and
> the platform is not ACPI-based. The warning might be crucial for
> debugging Wi-Fi issues on such platforms.

Sorry, I should have tried better with that commit message. V2 in a 
second.