linux-kernel - [PATCH] trace-cmd: fixup more bogus symbol resolutions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170216225721.13087-1-julia@ni.com>
Date:   Thu, 16 Feb 2017 16:57:21 -0600
From:   Julia Cartwright <julia@...com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     <linux-kernel@...r.kernel.org>, Jan Kiszka <jan.kiszka@...mens.com>
Subject: [PATCH] trace-cmd: fixup more bogus symbol resolutions

Commit ce1cbc51c ("trace-cmd: Leave out absolute addresses to fix bogus
symbol resolutions") fixed up bogus symbol resolution for 'A' type
symbols used on x86_64 for percpu offsets.

However, this check did not cover per-cpu variables used in modules,
which are generated as 'local' absolute symbols, and therefore appear as 'a' in
/proc/kallsyms.  Fix this.

Cc: Jan Kiszka <jan.kiszka@...mens.com>
Signed-off-by: Julia Cartwright <julia@...com>
---
 trace-util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/trace-util.c b/trace-util.c
index 5bf591c..fc5926e 100644
--- a/trace-util.c
+++ b/trace-util.c
@@ -458,7 +458,7 @@ void parse_proc_kallsyms(struct pevent *pevent,
 		 *  - arm arch that adds a lot of bogus '$a' functions
 		 *  - x86-64 that reports per-cpu variable offsets as absolute
 		 */
-		if (func[0] != '$' && ch != 'A')
+		if (func[0] != '$' && ch != 'A' && ch != 'a')
 			pevent_register_function(pevent, func, addr, mod);
 		free(func);
 		free(mod);
-- 
2.11.1