linux-kernel - Re: [PATCH v3 3/9] raid5: Don't reinvent the wheel but use existing llist API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Feb 2017 14:48:43 -0800
From:   Shaohua Li <shli@...nel.org>
To:     Byungchul Park <byungchul.park@....com>
Cc:     peterz@...radead.org, mingo@...nel.org, neilb@...e.de,
        nab@...ux-iscsi.org, viro@...iv.linux.org.uk, ying.huang@...el.com,
        oleg@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/9] raid5: Don't reinvent the wheel but use existing
 llist API

On Tue, Feb 14, 2017 at 04:26:24PM +0900, Byungchul Park wrote:
> Although llist provides proper APIs, they are not used. Make them used.

This one has no dependence of previous patches, so I added to md tree.

Thanks,
Shaohua 
> Signed-off-by: Byungchul Park <byungchul.park@....com>
> ---
>  drivers/md/raid5.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 36c13e4..22a0326 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -353,17 +353,15 @@ static void release_inactive_stripe_list(struct r5conf *conf,
>  static int release_stripe_list(struct r5conf *conf,
>  			       struct list_head *temp_inactive_list)
>  {
> -	struct stripe_head *sh;
> +	struct stripe_head *sh, *t;
>  	int count = 0;
>  	struct llist_node *head;
>  
>  	head = llist_del_all(&conf->released_stripes);
>  	head = llist_reverse_order(head);
> -	while (head) {
> +	llist_for_each_entry_safe(sh, t, head, release_list) {
>  		int hash;
>  
> -		sh = llist_entry(head, struct stripe_head, release_list);
> -		head = llist_next(head);
>  		/* sh could be readded after STRIPE_ON_RELEASE_LIST is cleard */
>  		smp_mb();
>  		clear_bit(STRIPE_ON_RELEASE_LIST, &sh->state);
> -- 
> 1.9.1
>