linux-kernel - Re: [PATCH 1/2] mmc: meson-gx: prevent cfg_div

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7ea0b57-efa0-58a5-92d5-8bc97f357f4c@webczatnet.pl>
Date:   Fri, 17 Feb 2017 20:49:23 +0100
From:   Michał Zegan <webczat@...czatnet.pl>
To:     Kevin Hilman <khilman@...libre.com>
Cc:     Carlo Caione <carlo@...one.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mmc@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being
 disabled on init



W dniu 17.02.2017 o 20:44, Kevin Hilman pisze:
> Michał Zegan <webczat@...czatnet.pl> writes:
>
>> At the end of function meson_mmc_clk_init, the cfg_div clock was
>> prepared, enabled and configured, but then immediately disabled due to bogus if statements.
>> That made later calls to clk_disable_unprepare executed during module removal to fail with a kernel warning.
>> Fix that by changing the code to disable clock only when it failed to be configured.
>>
>> Signed-off-by: Michał Zegan <webczat@...czatnet.pl>
> I believe this one is not needed any more after Heiner's cleanups?
I think it is not needed, yes.
>
> Kevin