linux-kernel - Re: [PATCH 2/2] mmc: meson-gx: remove mmc host on device removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <171193cd-e82d-695a-22b3-c10d670baad7@webczatnet.pl>
Date:   Fri, 17 Feb 2017 20:50:55 +0100
From:   Michał Zegan <webczat@...czatnet.pl>
To:     Kevin Hilman <khilman@...libre.com>
Cc:     Carlo Caione <carlo@...one.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mmc@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mmc: meson-gx: remove mmc host on device removal



W dniu 17.02.2017 o 20:47, Kevin Hilman pisze:
> Michał Zegan <webczat@...czatnet.pl> writes:
>
>> The mmc host was added in meson_mmc_probe, but never removed in meson_mmc_remove.
>> Fix that by removing the host before deallocating other resources.
>>
>> Signed-off-by: Michał Zegan <webczat@...czatnet.pl>
> Reviewed-by: Kevin Hilman <khilman@...libre.com>
I do not know how the mmc driver looks like after Heiner's cleanup. Does
this patch get obsoleted by the prior cleanup, or conflict with it in
some way?
>
>> ---
>>  drivers/mmc/host/meson-gx-mmc.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>> index d444b6bfa02b..bb83446118a3 100644
>> --- a/drivers/mmc/host/meson-gx-mmc.c
>> +++ b/drivers/mmc/host/meson-gx-mmc.c
>> @@ -818,6 +818,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
>>  	if (WARN_ON(!host))
>>  		return 0;
>>  
>> +	mmc_remove_host(host->mmc);
>> +
>>  	if (host->bounce_buf)
>>  		dma_free_coherent(host->dev, host->bounce_buf_size,
>>  				  host->bounce_buf, host->bounce_dma_addr);