linux-kernel - Re: [PATCH v3 1/5] vfs: Add file timestamp range support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170219015638.GG29622@ZenIV.linux.org.uk>
Date:   Sun, 19 Feb 2017 01:56:43 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Deepa Dinamani <deepa.kernel@...il.com>
Cc:     tytso@....edu, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, arnd@...db.de, y2038@...ts.linaro.org
Subject: Re: [PATCH v3 1/5] vfs: Add file timestamp range support

On Sat, Feb 18, 2017 at 03:30:04PM -0800, Deepa Dinamani wrote:
> Add fields to the superblock to track the min and max
> timestamps supported by filesystems.
> 
> Initially, when a superblock is allocated, initialize
> it to the max and min values the fields can hold.
> Individual filesystems override these to match their
> actual limits.
> 
> Pseudo filesystems are assumed to always support the
> min and max allowable values for the fields.

> @@ -257,6 +257,8 @@ struct dentry *mount_pseudo_xattr(struct file_system_type *fs_type, char *name,
> +	s->s_time_min = TIME64_MIN;
> +	s->s_time_max = TIME64_MAX;
> @@ -518,6 +520,8 @@ int simple_fill_super(struct super_block *s, unsigned long magic,
> +	s->s_time_min = TIME64_MIN;
> +	s->s_time_max = TIME64_MAX;
> @@ -247,6 +247,8 @@ static struct super_block *alloc_super(struct file_system_type *type, int flags,
> +	s->s_time_min = TIME64_MIN;
> +	s->s_time_max = TIME64_MAX;

If we always initialize them that way, why does libfs.c code bother
reassign the same values?