linux-kernel - Re: [PATCH v3 4/5] vfs: Add timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 19 Feb 2017 14:26:05 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Deepa Dinamani <deepa.kernel@...il.com>
Cc:     kbuild-all@...org, viro@...iv.linux.org.uk, tytso@....edu,
        adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        arnd@...db.de, y2038@...ts.linaro.org
Subject: Re: [PATCH v3 4/5] vfs: Add timestamp_truncate() api

Hi Deepa,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.10-rc8 next-20170217]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Deepa-Dinamani/vfs-Add-timestamp-range-check-support/20170219-073734
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   fs/inode.c:1679: warning: No description found for parameter 'rcu'
   fs/inode.c:2125: warning: No description found for parameter 'inode'
>> fs/inode.c:2125: warning: Excess function parameter 'gran' description in 'timestamp_truncate'
   include/linux/jbd2.h:442: warning: No description found for parameter 'i_transaction'
   include/linux/jbd2.h:442: warning: No description found for parameter 'i_next_transaction'
   include/linux/jbd2.h:442: warning: No description found for parameter 'i_list'
   include/linux/jbd2.h:442: warning: No description found for parameter 'i_vfs_inode'
   include/linux/jbd2.h:442: warning: No description found for parameter 'i_flags'
   include/linux/jbd2.h:494: warning: No description found for parameter 'h_rsv_handle'
   include/linux/jbd2.h:494: warning: No description found for parameter 'h_reserved'
   include/linux/jbd2.h:494: warning: No description found for parameter 'h_type'
   include/linux/jbd2.h:494: warning: No description found for parameter 'h_line_no'
   include/linux/jbd2.h:494: warning: No description found for parameter 'h_start_jiffies'
   include/linux/jbd2.h:494: warning: No description found for parameter 'h_requested_credits'
   include/linux/jbd2.h:1047: warning: No description found for parameter 'j_chkpt_bhs[JBD2_NR_BATCH]'
   include/linux/jbd2.h:1047: warning: No description found for parameter 'j_devname[BDEVNAME_SIZE+24]'
   include/linux/jbd2.h:1047: warning: No description found for parameter 'j_average_commit_time'
   include/linux/jbd2.h:1047: warning: No description found for parameter 'j_min_batch_time'
   include/linux/jbd2.h:1047: warning: No description found for parameter 'j_max_batch_time'
   include/linux/jbd2.h:1047: warning: No description found for parameter 'j_commit_callback'
   include/linux/jbd2.h:1047: warning: No description found for parameter 'j_failed_commit'
   include/linux/jbd2.h:1047: warning: No description found for parameter 'j_chksum_driver'
   include/linux/jbd2.h:1047: warning: No description found for parameter 'j_csum_seed'
   fs/jbd2/transaction.c:428: warning: No description found for parameter 'rsv_blocks'
   fs/jbd2/transaction.c:428: warning: No description found for parameter 'gfp_mask'
   fs/jbd2/transaction.c:428: warning: No description found for parameter 'type'
   fs/jbd2/transaction.c:428: warning: No description found for parameter 'line_no'
   fs/jbd2/transaction.c:504: warning: No description found for parameter 'type'
   fs/jbd2/transaction.c:504: warning: No description found for parameter 'line_no'
   fs/jbd2/transaction.c:634: warning: No description found for parameter 'gfp_mask'

vim +2125 fs/inode.c

  2109	
  2110	void inode_nohighmem(struct inode *inode)
  2111	{
  2112		mapping_set_gfp_mask(inode->i_mapping, GFP_USER);
  2113	}
  2114	EXPORT_SYMBOL(inode_nohighmem);
  2115	
  2116	/**
  2117	 * fs_timespec_trunc - Truncate timespec to a granularity
  2118	 * @t: Timespec
  2119	 * @gran: Granularity in ns.
  2120	 *
  2121	 * Truncate a timespec to a granularity. Always rounds down. gran must
  2122	 * not be 0 nor greater than a second (NSEC_PER_SEC, or 10^9 ns).
  2123	 */
  2124	struct timespec timestamp_truncate(struct timespec t, struct inode *inode)
> 2125	{
  2126		struct super_block *sb = inode->i_sb;
  2127		unsigned int gran = sb->s_time_gran;
  2128	
  2129		t.tv_sec = clamp_t(time64_t, t.tv_sec, sb->s_time_min, sb->s_time_max);
  2130	
  2131		/* Avoid division in the common cases 1 ns and 1 s. */
  2132		if (gran == 1) {
  2133			/* nothing */

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (6457 bytes)