linux-kernel - Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa845fa1-4689-cdac-bbf5-0bab19e003dd@metafoo.de>
Date:   Mon, 20 Feb 2017 13:07:38 +0100
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     jic23@...nel.org, linux-iio@...r.kernel.org, knaack.h@....de,
        pmeerw@...erw.net, dmitry.torokhov@...il.com,
        michael.hennerich@...log.com, daniel.baluta@...il.com,
        amsfield22@...il.com, florian.vaussard@...g-vd.ch,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support

On 02/19/2017 01:15 PM, Eva Rachel Retuya wrote:
> On Sun, Feb 19, 2017 at 11:01:23AM +0100, Lars-Peter Clausen wrote:
>> On 02/16/2017 11:02 AM, Eva Rachel Retuya wrote:
>> [...]
>>> @@ -54,9 +55,17 @@ static const struct i2c_device_id adxl345_i2c_id[] = {
>>>  
>>>  MODULE_DEVICE_TABLE(i2c, adxl345_i2c_id);
>>>  
>>> +static const struct acpi_device_id adxl345_acpi_id[] = {
>>> +	{ "ADX0345", 0 },
>>
>> Who allocated this ID? ADX does not seem to be a registered vendor ID
>> (http://www.uefi.org/PNP_ACPI_Registry).
>>
> 
> Hello Lars,
> 
> Pardon the ignorance. I was not aware of this when I set it like that.
> Is "ADS0345" OK? Will submit a new version with that ID.

Excellent question. ACPI is not like devicetree where we can just randomly
choose IDs. The namespaces are more controlled. The vendor IDs are managed
and allocated by the UEFI forum, each vendor then allocates device IDs in
its vendor namespace for specific purposes. Unless you own a vendor ID or
the device ID has been allocated by the vendor for you you shouldn't use the ID.

If you have a ACPI based system which features the adxl345 maybe using
PRP0001[1] might be the better approach.

- Lars

[1] https://www.kernel.org/doc/Documentation/acpi/enumeration.txt