linux-kernel - Re: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170220133431.GB5656@osiris>
Date:   Mon, 20 Feb 2017 14:34:31 +0100
From:   Heiko Carstens <heiko.carstens@...ibm.com>
To:     Elena Reshetova <elena.reshetova@...el.com>,
        linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
        x86@...nel.org, sparclinux@...r.kernel.org,
        linux-s390@...r.kernel.org, kvm@...r.kernel.org,
        peterz@...radead.org, gregkh@...uxfoundation.org,
        davem@...emloft.net, tglx@...utronix.de, mingo@...hat.com,
        tony.luck@...el.com, hpa@...or.com,
        Hans Liljestrand <ishkamiel@...il.com>,
        Kees Cook <keescook@...omium.org>,
        David Windsor <dwindsor@...il.com>
Subject: Re: [PATCH 1/4] s390: convert debug_info.ref_count from atomic_t to
 refcount_t

On Mon, Feb 20, 2017 at 02:24:24PM +0100, Heiko Carstens wrote:
> > @@ -361,7 +361,7 @@ debug_info_create(const char *name, int pages_per_area, int nr_areas,
> >          debug_area_last = rc;
> >          rc->next = NULL;
> >  
> > -	debug_info_get(rc);
> > +	refcount_set(&rc->ref_count, 1);
> 
> This is not wrong, but I will remove this hunk before applying your patch,
> since this doesn't look like an obvious correct change at first glance.

Actually your version is needed - just looked at refcount_inc().
Sorry for the confusion in my side now.