linux-kernel - Re: [PATCH] ipmi: bt-bmc: Use a regmap for register access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fe8fe1f-e035-8ef1-cecd-d3d29bcda075@acm.org>
Date:   Mon, 20 Feb 2017 07:35:16 -0600
From:   Corey Minyard <minyard@....org>
To:     Andrew Jeffery <andrew@...id.au>,
        Cédric Le Goater <clg@...d.org>
Cc:     Joel Stanley <joel@....id.au>,
        openipmi-developer@...ts.sourceforge.net,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi: bt-bmc: Use a regmap for register access

On 02/19/2017 10:45 PM, Andrew Jeffery wrote:
> Hi Cory,
>
> On Tue, 2016-12-06 at 16:02 +0100, Cédric Le Goater wrote:
>> [ this is a resend bc of some mailing list issues]
>>
>> On 12/06/2016 03:57 AM, Andrew Jeffery wrote:
>>> The registers for the bt-bmc device live under the Aspeed LPC
>>> controller. Devicetree bindings have recently been introduced for the
>>> LPC controller where the "host" portion of the LPC register space is
>>> described as a syscon device. Future devicetrees describing the bt-bmc
>>> device should nest its node under the appropriate "simple-mfd", "syscon"
>>> compatible node.
>>>
>>> This change allows the bt-bmc driver to function with both syscon and
>>> non-syscon- based devicetree descriptions by always using a regmap for
>>> register access, either retrieved from the parent syscon device or
>>> instantiated if none exists.
>>>
>>> The patch has been tested on an OpenPOWER Palmetto machine, successfully
>>> booting, rebooting and powering down the host.
>>>
>>> Signed-off-by: Andrew Jeffery <andrew@...id.au>
>> It would be nice to have an example of the associated binding.
>> I did not see it. A part from that :
>>
>> Reviewed-by: Cédric Le Goater <clg@...d.org>
>
> Will this make it into 4.11?

I thought you were doing a v2 with a few little fixes.  Get it to me 
quickly, if you can.

-corey

> Cheers,
>
> Andrew