linux-kernel - Re: [PATCH] Staging: board: Fix macro code style error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Feb 2017 18:55:06 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Valentin Huebner <valentin.huebner@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: board: Fix macro code style error

On Mon, Feb 20, 2017 at 05:44:50PM +0000, Valentin Huebner wrote:
> Fixes a 'macro with flow control statement' checkpatch code style
> error by removing the board_staging() macro and replacing its two
> calls

checkpatch is wrong here, you are now adding more lines than you remove:

> Signed-off-by: Valentin Hübner <valentin.huebner@...il.com>
> ---
>  drivers/staging/board/armadillo800eva.c | 10 +++++++++-
>  drivers/staging/board/board.h           | 11 -----------
>  drivers/staging/board/kzm9d.c           | 10 +++++++++-
>  3 files changed, 18 insertions(+), 13 deletions(-)

See?

There's nothing wrong with the macro as-is, it's like many other macros
we have for module init sequences.  checkpatch is just a hint, you still
have to use your brain :)

sorry,

greg k-h