lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 23 Feb 2017 08:34:15 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Frederic Weisbecker <fweisbec@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Frederic Weisbecker <fweisbec@...il.com>,
        Abdul Haleem <abdhalee@...ux.vnet.ibm.com>,
        Oliver O'Halloran <oohall@...il.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] powerpc: Remove leftover cputime_to_nsecs call causing build error

Frederic Weisbecker <fweisbec@...il.com> writes:

> This type conversion is a leftover that got ignored during the kcpustat
> conversion to nanosecs, resulting in build breakage with config having
> CONFIG_NO_HZ_FULL=y.
>
> 	arch/powerpc/kernel/time.c: In function 'running_clock':
> 	arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function 'cputime_to_nsecs' [-Werror=implicit-function-declaration]
> 	  return local_clock() - cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
>
> All we need is to remove it.
>
> Reported-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Oliver O'Halloran <oohall@...il.com>
> Cc: linuxppc-dev@...ts.ozlabs.org
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>

LGTM.

Acked-by: Michael Ellerman <mpe@...erman.id.au>


Are you going to send this to Linus, or should I?

cheers


> diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c
> index 14e4855..bc84a8d 100644
> --- a/arch/powerpc/kernel/time.c
> +++ b/arch/powerpc/kernel/time.c
> @@ -709,7 +709,7 @@ unsigned long long running_clock(void)
>  	 * time and on a host which doesn't do any virtualisation TB *should* equal
>  	 * VTB so it makes no difference anyway.
>  	 */
> -	return local_clock() - cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
> +	return local_clock() - kcpustat_this_cpu->cpustat[CPUTIME_STEAL];
>  }
>  #endif
>  
> -- 
> 2.7.4

Powered by blists - more mailing lists