[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170223083631.GE18639@dtor-ws>
Date: Thu, 23 Feb 2017 00:36:31 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Pau Espin Pedrol <pespin.shar@...il.com>,
Andy Shevchenko <andy@...radead.org>,
Platform Driver <platform-driver-x86@...r.kernel.org>,
Corentin Chary <corentin.chary@...il.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>,
"dvhart@...radead.org" <dvhart@...radead.org>
Subject: Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51
On Tue, Feb 21, 2017 at 05:38:59PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 21, 2017 at 3:39 PM, Pau Espin Pedrol <pespin.shar@...il.com> wrote:
>
> > If we have user space tools supporting and using this type of event,
> > then what about adding them properly with a define + entry in the
> > structure array so that it can be standardized and on top get rid of
> > those kernel message every time I (un)plug the charger? Would that be
> > welcomed? I could send a new patch as specified above, adding the
> > KEY_CHARING_ON/OFF defines + add entries to eeepc_keymap.
>
> Please, do not top posting.
>
> Dmitry, do we have special events for AC (un)plug? What is the best
> approach in your opinion?
Not route them through input as they not input events would be the best.
I'd look into hooking up power_supply class.
Thanks.
--
Dmitry
Powered by blists - more mailing lists